Re: [PATCH 2/4] gpio: max732x: Rewrite IRQ code to use irq_domain API

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Jan 13, 2015 at 2:41 PM, Semen Protsenko
<semen.protsenko@xxxxxxxxxxxxxxx> wrote:

> Signed-off-by: Semen Protsenko <semen.protsenko@xxxxxxxxxxxxxxx>

This makes the code *so* much better so patch applied, naturally.

But...

>  config GPIO_MAX732X
>         tristate "MAX7319, MAX7320-7327 I2C Port Expanders"
>         depends on I2C
> +       select IRQ_DOMAIN

The most modern way would be to take another step and convert the
driver to GPIOLIB_IRQCHIP by stating

select GPIOLIB_IRQCHIP

here.

If you look at other drivers using GPIOLIB_IRQCHIP on an
i2c expander, say gpio-stmpe.c or gpio-tc3589x.c, you
can get a grip on how that works.

So please follow up with a patch converting the driver to
GPIOLIB_IRQCHIP on top of these patches :) if you
have time.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html