Re: [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags

[Alexandre Courbot <gnurou@xxxxxxxxx>]

On Fri, Jan 9, 2015 at 5:40 PM, Hans Holmberg <hans.holmberg@xxxxxxxxx> wrote:
> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
> where the gpio chip is available and the GPIO translation fails.
>
> This causes drivers to be re-probed erroneusly, and hides the
> real problem(i.e. the GPIO number being out of range).
>
> Signed-off-by: Hans Holmberg <hans.holmberg@xxxxxxxxx>
> ---
>  drivers/gpio/gpiolib-of.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 604dbe6..08261f2 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -45,8 +45,14 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
>                 return false;
>
>         ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags);
> -       if (ret < 0)
> -               return false;
> +       if (ret < 0) {
> +               /* We've found the gpio chip, but the translation failed.
> +                * Return true to stop looking and return the translation
> +                * error via out_gpio
> +                */
> +               gg_data->out_gpio = ERR_PTR(ret);
> +               return true;
> +        }

Nice catch.

Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html