Re: [PATCH RFT] gpio: dln2: Fix gpio output value in dln2_gpio_direction_output()

[Octavian Purdila <octavian.purdila@xxxxxxxxx>]

On Tue, Dec 16, 2014 at 6:52 PM, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote:
>
>
> On 12/16/2014 04:40 PM, Axel Lin wrote:

Hi Axel,

Nice catch!

>>
>> dln2_gpio_direction_output() ignored the state passed into it. Fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
>
>
> Tested-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
>
>> ---
>> I don't have this hardware handy, so only compile test.
>>   drivers/gpio/gpio-dln2.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
>> index 978b51e..1434844 100644
>> --- a/drivers/gpio/gpio-dln2.c
>> +++ b/drivers/gpio/gpio-dln2.c
>> @@ -267,6 +267,7 @@ static int dln2_gpio_direction_input(struct gpio_chip
>> *chip, unsigned offset)
>>   static int dln2_gpio_direction_output(struct gpio_chip *chip, unsigned
>> offset,
>>                                       int value)
>>   {
>> +       dln2_gpio_set(chip, offset, value);

Could you change dln2_gpio_pin_set_out_val's signature to return an
error code than use it instead of dln2_gpio_set here? Then we can
check the error value. With that:

Reviewed-by: Octavian Purdila <octavian.purdila@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html