Re: [GIT PULL] bulk GPIO changes for v3.19

[Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>]

On Tue, Dec 9, 2014 at 1:09 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> here is the bulk of GPIO changes for the v3.19 kernel series.
> The major external change is the new API to driver several GPIOs
> simultaneously, and the major internal change is that we're getting
> rid of a static array of GPIO descriptors and again moving away,
> slowly, from the global GPIO numberspace.

This does not build for me.

The gpio-mcp23s08.c driver now has a "chip.of_node" access outside of
#ifdef CONFIG_OF, resulting in

  drivers/gpio/gpio-mcp23s08.c: In function ‘mcp23s08_probe_one’:
  drivers/gpio/gpio-mcp23s08.c:658:57: error: ‘struct gpio_chip’ has
no member named ‘of_node’
     mcp->irq_active_high = of_property_read_bool(mcp->chip.of_node,

Should it be using "mcp->chip.dev->of_node" instead? Or should the
driver just depend on OF?

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html