Re: [PATCH v2] gpio: remove const modifier from gpiod_get_direction()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Nov 25, 2014 at 9:16 AM, Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:

> Although gpiod_get_direction() can be considered side-effect free for
> consumers, its internals involve setting or clearing bits in the
> affected GPIO descriptor, for which we need to force-cast the const
> descriptor variable to non-const. This could lead to incorrect behavior
> if the compiler decides to optimize here, so remove this const
> attribute. The intent is to make gpiod_get_direction() private anyway,
> so it does not really matter.
>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Fixed poor grammar in commit log
> - Added Uwe's Ack

Patch applied after crying blood of the quoted-printable encoding
of this mail.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html