Re: [PATCH] gpio: rcar: Add r8a7793 and r8a7794 support

[Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>]

Hi Geert-san,

2014-11-07 19:51 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Kaneko-san,
>
> On Fri, Nov 7, 2014 at 11:49 AM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>>> Given we now have 4 identical copies of the above struct gpio_rcar_info,
>>> I think it starts to make sense to create
>>>
>>>         static struct gpio_rcar_info gpio_rcar_info_gen2 = {
>>>                 .has_both_edge_trigger = true;
>>>         };
>>>
>>> and just reference that one from gpio_rcar_of_table[].
>>> While at it, you can do the same for R-Car Gen 1 for consistency.
>>
>> Is the following what you intended?
>
> Yes, thank you very much.
>
> Please add a similar struct for R-Car Gen1.

I'm not sure about R-Car Gen1.
Is it the following things?

+static const struct gpio_rcar_info gpio_rcar_info_gen1 = {
+       .has_both_edge_trigger = false,
+};
[...]
        }, {
                .compatible = "renesas,gpio-rcar",
-               .data = (void *)&(const struct gpio_rcar_info) {
-                       .has_both_edge_trigger = false,
-               },
+               .data = &gpio_rcar_info_gen1,
        }, {


Thanks,
Kaneko

>
>> +static const struct gpio_rcar_info gpio_rcar_info_gen2 = {
>> +       .has_both_edge_trigger = true,
>> +};
>> +
>>  static const struct of_device_id gpio_rcar_of_table[] = {
>>         {
>>                 .compatible = "renesas,gpio-r8a7790",
>> -               .data = (void *)&(const struct gpio_rcar_info) {
>> -                       .has_both_edge_trigger = true,
>> -               },
>> +               .data = &gpio_rcar_info_gen2,
>>         }, {
>>                 .compatible = "renesas,gpio-r8a7791",
>> -               .data = (void *)&(const struct gpio_rcar_info) {
>> -                       .has_both_edge_trigger = true,
>> -               },
>> +               .data = &gpio_rcar_info_gen2,
>> +       }, {
>> +               .compatible = "renesas,gpio-r8a7793",
>> +               .data = &gpio_rcar_info_gen2,
>> +       }, {
>> +               .compatible = "renesas,gpio-r8a7794",
>> +               .data = &gpio_rcar_info_gen2,
>>         }, {
>>                 .compatible = "renesas,gpio-rcar",
>>                 .data = (void *)&(const struct gpio_rcar_info) {
>>                         .has_both_edge_trigger = false,
>>                 },
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html