Re: [PATCHv2 2/3] gpio: sch: Add support for Intel Quark X1000 SoC

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Sep 26, 2014 at 1:07 PM, Chang Rebecca Swee Fun
<rebecca.swee.fun.chang@xxxxxxxxx> wrote:
> Intel Quark X1000 provides a total of 16 GPIOs. The GPIOs are split between
> the legacy I/O bridge and the GPIO controller.
>
> GPIO-SCH is the GPIO pins on legacy bridge for Intel Quark SoC.
> Intel Quark X1000 has 2 GPIOs powered by the core power well and 6 from
> the suspend power well.
>
> This piece of work is derived from Dan O'Donovan's initial work for Quark
> X1000 enabling.
>
> Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@xxxxxxxxx>
> ---
>  drivers/gpio/Kconfig    |   11 +++++++++--
>  drivers/gpio/gpio-sch.c |    6 ++++++
>  2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 690904a..64683a9 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -356,25 +356,32 @@ config GPIO_VR41XX
>           Say yes here to support the NEC VR4100 series General-purpose I/O Uint
>
>  config GPIO_SCH
> -       tristate "Intel SCH/TunnelCreek/Centerton GPIO"
> +       tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"

Do we need 'X1000' here right now?

>         depends on PCI && X86
>         select MFD_CORE
>         select LPC_SCH
>         help
>           Say yes here to support GPIO interface on Intel Poulsbo SCH,
> -         Intel Tunnel Creek processor or Intel Centerton processor.
> +         Intel Tunnel Creek processor, Intel Centerton processor or

I think you may use comma before 'or' word.

> +         Intel Quark X1000 SoC.
> +
>           The Intel SCH contains a total of 14 GPIO pins. Ten GPIOs are
>           powered by the core power rail and are turned off during sleep
>           modes (S3 and higher). The remaining four GPIOs are powered by
>           the Intel SCH suspend power supply. These GPIOs remain
>           active during S3. The suspend powered GPIOs can be used to wake the
>           system from the Suspend-to-RAM state.
> +
>           The Intel Tunnel Creek processor has 5 GPIOs powered by the
>           core power rail and 9 from suspend power supply.
> +
>           The Intel Centerton processor has a total of 30 GPIO pins.
>           Twenty-one are powered by the core power rail and 9 from the
>           suspend power supply.
>
> +         The Intel Quark X1000 SoC has 2 GPIOs powered by the core
> +         power well and 6 from the suspend power well.
> +
>  config GPIO_ICH
>         tristate "Intel ICH GPIO"
>         depends on PCI && X86
> diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
> index 6e89be9..952990f 100644
> --- a/drivers/gpio/gpio-sch.c
> +++ b/drivers/gpio/gpio-sch.c
> @@ -241,6 +241,12 @@ static int sch_gpio_probe(struct platform_device *pdev)
>                 sch->chip.ngpio = 30;
>                 break;
>
> +       case PCI_DEVICE_ID_INTEL_QUARK_X1000_ILB:
> +               sch->core_base = 0;
> +               sch->resume_base = 2;
> +               sch->chip.ngpio = 8;
> +               break;
> +
>         default:
>                 return -ENODEV;
>         }
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html