Re: [PATCH] gpio: set parent irq on chained handlers

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Sep 26, 2014 at 2:20 PM, Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
> On 09/26/2014 02:52 PM, Linus Walleij wrote:
>> If the IRQ from the parent is nested the IRQ may need to be
>> resent under certain conditions. Currently the chained IRQ
>> handler in gpiolib does not handle connecting nested IRQs
>
> Seems there is still some misunderstanding ( - chained vs nested IRQs

Yeah trying to hash it out...

>> but it is conceptually correct to indicate the actual parent
>> IRQ.
>>
>> Reported-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
>
> + Reported-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>

OK.

>>       if (gpiochip->can_sleep) {
>>               chip_err(gpiochip, "you cannot have chained interrupts on a chip that may sleep\n");
>>               return;
>>       }
>
>
> This function can't be called by gpio-pca953x.c driver  (

Yeah I'm toying around with solutions for this...

> May be some simple helper can be added instead:
>  void gpiochip_set_nested_irqchip(struct gpio_chip *gpiochip,
>                                   int parent_irq)

That's one option. I'm trying to come up with something that
duplicates as little code as possible.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html