Re: [RFC/RFT PATCH 2/2] gpiolib: irqchip: get rid of irq_base

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 25, 2014 at 6:09 PM, Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:

> Remove irq_base from struct gpio_chip, as it is seems to
> be unused.
> Aslo, using this field by drivers is unsafe because it's
> uncompatible with Sparse IRQ feature.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> ---
> Hi Linus,
>
> I've not found users of this field in drivers/gpio/ folder,
> so I've decided to created this patch to get more comments.

Wut?

git grep '>irq_base'
(...)
drivers/gpio/gpio-max732x.c:    return chip->irq_base + off;
drivers/gpio/gpio-ml-ioh.c:     return chip->irq_base + offset;
drivers/gpio/gpio-pch.c:        chip->irq_base = irq_base;
etc etc

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html