Re: [PATCH 2/2] GPIO: 74xx-mmio: Add DT bindings documentation

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Sep 23, 2014 at 6:51 PM, Alexander Shiyan <shc_work@xxxxxxx> wrote:
> Mon, 22 Sep 2014 13:39:26 +0200 от Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>> On Fri, Sep 19, 2014 at 9:40 AM, Alexander Shiyan <shc_work@xxxxxxx> wrote:
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/gpio/gpio-74xx-mmio.txt
>> > @@ -0,0 +1,30 @@
>> > +* 74XX MMIO GPIO driver
>> > +
>> > +Required properties:
>> > +- compatible: Should contain one of the following:
>> > +   "ti,74ahc1g125": for 74AHC1G125 (1-bit Input),
>> > +   "ti,74auc1g174": for 74AUC1G74 (1-bit Output),
>> > +   "ti,74lvc2g125": for 74LVC2G125 (2-bit Input),
>> > +   "ti,74hc74":     for 74HC74 (2-bit Output),
>> > +   "ti,74hc125":    for 74HC125 (4-bit Input),
>> > +   "ti,74hc175":    for 74HC175 (4-bit Output),
>> > +   "ti,74hc365":    for 74HC365 (6-bit Input),
>> > +   "ti,74hc174":    for 74HC174 (6-bit Output),
>> > +   "ti,74hc244":    for 74HC244 (8-bit Input),
>> > +   "ti,74hc273":    for 74HC273 (8-bit Output),
>> > +   "ti,74ac1624":   for 74AC1624 (16-bit Input),
>> > +   "ti,74ac16374":  for 74AC16374 (16-bit Output).
>>
>> As the actual implementation technology doesn't matter, I think you
>> should use the base name where appropriate.
>> E.g. "ti,7474" instead of "ti,74hc74".
>
> Make sense.
>
> Linus, what you think overall about this driver?

That's a question about patch 1/2, and I haven't gotten to it
yet. High incoming patch rate.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html