Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver

[atull <atull@xxxxxxxxxxxxxxxxxxxxx>]

On Thu, 11 Sep 2014, Shevchenko, Andriy wrote:

> On Wed, 2014-09-10 at 14:11 -0500, atull wrote:
> 
> []
> 
> > >  static int dwapb_gpio_probe(struct platform_device *pdev)
> > >  {
> > > +	int i;
> > >  	struct resource *res;
> > >  	struct dwapb_gpio *gpio;
> > > -	struct device_node *np;
> > >  	int err;
> > > -	unsigned int offs = 0;
> > > +	struct device *dev = &pdev->dev;
> > > +	struct dwapb_platform_data *pdata = dev_get_platdata(dev);
> > > +	bool is_pdata_alloc = !pdata;
> > 
> > Please combine the int's in one line (int err, i;) and put them as
> > the last one on this list.  It looks the same to the compiler of
> > course, but more uniform for human eyes :)
> 
> Do you think it's a good idea? In this case I, for example, would like
> to see int err as a separate line at the end of definition block. It
> would be better to distinguish counters and return code storage.
> Moreover, often counters would be unsigned int.

If they are both 'int' they should be combined.  If 'i' is changed to be
an unsigned int they would be separate.

> 
> -- 
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Intel Finland Oy
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki 
> Business Identity Code: 0357606 - 4 
> Domiciled in Helsinki 
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 

Andy,

This confidentiality footer is problematic on this mailing list.  Please
see https://lkml.org/lkml/2014/3/5/790 for example.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html