Re: [PATCH v3] gpiolib: Export gpiochip_request_own_desc and gpiochip_free_own_desc

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Tue, Jul 22, 2014 at 08:01:01AM -0700, Guenter Roeck wrote:
> Both functions were introduced to let gpio drivers request their own
> gpio pins. Without exporting the functions, this can however only be
> used by gpio drivers built into the kernel.
> 
> Secondary impact is that the functions can not currently be used by
> platform initialization code associated with the gpio-pca953x driver.
> This code permits auto-export of gpio pins through platform data, but
> if this functionality is used, the module can no longer be unloaded due
> to the problem solved with the introduction of gpiochip_request_own_desc
> and gpiochip_free_own_desc.
> 
> Export both function so they can be used from modules and from
> platform initialization code.
> 
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Looks good to me, thanks.

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html