Re: [PATCH 1/2][v5] gpiolib: allow simultaneous setting of multiple GPIO outputs

[Rojhalat Ibrahim <imr@xxxxxxxxxxx>]

On Monday 07 July 2014 17:23:34 Linus Walleij wrote:
> On Mon, Jun 16, 2014 at 3:51 PM, Rojhalat Ibrahim <imr@xxxxxxxxxxx> wrote:
> 
> > Introduce new functions gpiod_set_array & gpiod_set_raw_array to the consumer
> > interface which allow setting multiple outputs with just one function call.
> > Also add an optional set_multiple function to the driver interface. Without an
> > implementation of that function in the chip driver outputs are set
> > sequentially.
> 
> Yes this looks good.
> 
> Except for one thing I mentioned quite early  I think:
> 
> no users!
> 

I'm pretty sure you did _not_ mention this before.

> How am I supposed to test this?
> 
> I wanted to see a patch also switching the one in-kernel thing that
> really needs this switched over to using this functionality.
> 
> That means, a patch to drivers/i2c/busses/i2c-gpio.c
> to set scl+sda in one go, for example.
> 
> Or a similar patch to drivers/spi/spi-gpio.c I guess?
> 
> Something that makes sense. As a bonus you get to rewrite
> one of these drivers to use GPIO descriptors ;)
> 
> This is not a hard wall, but I highly suspect that there must be
> some driver using this if you want to implement it, right? And the
> two mentioned drivers will be easy to use to test the feature on
> a lot of platforms.
> 

I'll take a look at those drivers and hopefully come back with an extended
patch set.

   Rojhalat

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html