Avoid code duplication by using devm_kmemdup() to copy data instead of having a separate loop within devm_kstrdup(). Reviewed-by: Ian Molton <ian.molton@xxxxxxxxxxxxxxx> Signed-off-by: Rob Jones <rob.jones@xxxxxxxxxxxxxxx> --- drivers/base/devres.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 9d0f64c..cf19664 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -802,17 +802,10 @@ EXPORT_SYMBOL_GPL(devm_kmalloc); */ char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) { - size_t size; - char *buf; - if (!s) return NULL; - size = strlen(s) + 1; - buf = devm_kmalloc(dev, size, gfp); - if (buf) - memcpy(buf, s, size); - return buf; + return devm_kmemdup(dev, s, (strlen(s) + 1), gfp); } EXPORT_SYMBOL_GPL(devm_kstrdup); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html