On Thu, May 29, 2014 at 12:10:02PM +0200, Linus Walleij wrote: > On Tue, May 27, 2014 at 1:14 PM, Rojhalat Ibrahim <imr@xxxxxxxxxxx> wrote: > > + void (*set_multiple)(struct gpio_chip *chip, > > + u32 *mask, u32 *bits); > This sets the chunk size to 32bits which means that any GPIO > controller with say 8bit registers will get a complex demuxing > scheme. > But thinking of it I think it's a reasonable compromise given that > so many GPIO drivers are actually 32bit. > However some of the real slow I2C expander GPIOs are 8bit. We can probably librify the demuxing code if we need it, though a lot of those devices only have 8 GPIOs in the first place which makes life a lot simpler since everything will always be in the same register anyway. Overall the interface here looks good modulo your concerns about ARCH_NR_GPIOs.
Attachment:
signature.asc
Description: Digital signature
