On Mon, May 19, 2014 at 01:39:33PM +0300, Mika Westerberg wrote: > On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote: > > Devices based on Intel SoC products such as Baytrail have a Power > > Management IC. In the PMIC there are subsystems for voltage regulation, > > A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called > > Crystal Cove. > > > > This patch adds support for the GPIO function in Crystal Cove. > > I have few comments as well in addition to comments from Linus and > Alexandre. One more thing, I just remembered. The crystal cove GPIO driver is supposed to provide ACPI Operation Regions to the ASL code so you need to make sure you have ACPI handle associated with the device before you register your driver to the GPIO core. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html