Yes sorry about the spam! I only realised after that I had HTML enabled
:)
On 13/05/2014 08:59, Alexandre Courbot wrote:
On Tue, May 13, 2014 at 2:54 AM, Anthony Fee <anthony.fee@xxxxxxxxxx>
wrote:
gpiolib will require all gpio drivers to expicitly set the request
function
pointer in future. To encourage gpio driver developers to adhere to
this
standard gpio-generic.c now sets this function pointer.
Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
for the non-HTML version. :)
On top of being future-proof, having the GPIO range check is also a
good thing.
Signed-off-by: Anthony Fee <anthony.fee@xxxxxxxxxx>
---
drivers/gpio/gpio-generic.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index b5dff9e..fea8c82 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -388,6 +388,14 @@ static int bgpio_setup_direction(struct
bgpio_chip
*bgc,
return 0;
}
+static int bgpio_request(struct gpio_chip *chip, unsigned gpio_pin)
+{
+ if (gpio_pin < chip->ngpio)
+ return 0;
+
+ return -EINVAL;
+}
+
int bgpio_remove(struct bgpio_chip *bgc)
{
return gpiochip_remove(&bgc->gc);
@@ -413,6 +421,7 @@ int bgpio_init(struct bgpio_chip *bgc, struct
device
*dev,
bgc->gc.label = dev_name(dev);
bgc->gc.base = -1;
bgc->gc.ngpio = bgc->bits;
+ bgc->gc.request = bgpio_request;
ret = bgpio_setup_io(bgc, dat, set, clr);
if (ret)
--
1.9.0
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio"
in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
