Re: [PATCH 0/4] use BIT() macro instead manually shifting bits

[Javier Martinez Canillas <javier@xxxxxxxxxxxx>]

Hello Linus,

On Sat, May 3, 2014 at 9:15 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Sat, Apr 26, 2014 at 5:00 PM, Javier Martinez Canillas
> <javier@xxxxxxxxxxxx> wrote:
>
>> Hello Linus and Alexandre,
>>
>> While learning coccinelle towards doing the big gpio_chip/gpio_chip_ops
>> split refactoring I wrote this trivial semantic patch that replaces a
>> manual bit shift by using the BIT macro from <linux/bitops.h>
>
> Nice semantic patch!
>

Thanks

> And all patches applied with Alex's ACK.
>
> However I will edit the commit messages to remove the word
> "manual". This just breaks my heart everytime I see that word
> used in code, manual means a person is typing the keys or something
> I bet it's still a computer doing the heavy lifting here.
>

Yes, I agree that the wording was not the best. Thanks a lot for
fixing the commit messages.

> Yours,
> Linus Walleij

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html