Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Javier Martinez Canillas <javier@xxxxxxxxxxxx>]

Hello Ezequiel,

On Thu, Apr 24, 2014 at 10:54 PM, Ezequiel Garcia
<ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:
> There's no reason to use an initcall to initialize this driver,
> and regular module_platform_driver() can be used instead.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-mvebu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index d425094..7d64cde 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -738,9 +738,4 @@ static struct platform_driver mvebu_gpio_driver = {
>         },
>         .probe          = mvebu_gpio_probe,
>  };
> -
> -static int __init mvebu_gpio_init(void)
> -{
> -       return platform_driver_register(&mvebu_gpio_driver);
> -}
> -postcore_initcall(mvebu_gpio_init);
> +module_platform_driver(mvebu_gpio_driver);
> --
> 1.9.1
>
> --

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html