Re: [PATCH v3] gpio: omap: implement get_direction

[Tony Lindgren <tony@xxxxxxxxxxx>]

* Santosh Shilimkar <santosh.shilimkar@xxxxxx> [140424 06:30]:
> On Thursday 24 April 2014 09:13 AM, Linus Walleij wrote:
> > On Thu, Apr 24, 2014 at 8:57 AM,  <yegorslists@xxxxxxxxxxxxxx> wrote:
> > 
> >> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> >>
> >> This patch implements gpio_chip's get_direction() routine, that
> >> lets other drivers get particular GPIOs direction using
> >> struct gpio_desc.
> >>
> >> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> >> Acked-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> >> ---
> >> Changes:
> >>         v3: get rid of _get_gpio_direction() (Linus Walleij)
> >>         v2: rework return value calculation
> > 
> > Looks good to me, Kevin, Santosh?
> > 
> Looks fine to me as well.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>

OK finally got around testing gpio/for-next here. Could not use
todays linux next as it's broken again for whatever reasons and
does not even compile for me.

Boot tested gpio/next on few omap1 boards: h2, osk and 770 and
things behave the same way as earlier for me on these boards.
Also made sure the PM does not break as tested on n900 with the
GPIO changes. So for the following patches, feel free to add:

cb2a5fb059b5 gpio: do not set up hardware for IRQ_TYPE_NONE
da09ceae78f7 gpio: omap: implement get_direction
d04b76626e94 gpio: omap: convert driver to use gpiolib irqchip
d4094cd7577c gpio: omap: check gpiochip_add() return value
820eade1b7f3 gpio: omap: convert to use irq_domain_add_simple()
717f70e39a98 gpio: omap: Use devm_ioremap_resource()

Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>

Naturally no need to go back to edit the commits for my acks
unless there are other reasons to redo the branches.

> > Part of me wants to list Javier as maintainer for this driver.
> > 
> Am ok with it as well.

That sounds good to me too, looks like Javier is doing a good job
on that already :)

Regards,

Tony 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html