Re: [PATCH 3/4] gpio: tc3589x: get rid of static IRQ base

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Apr 17, 2014 at 9:47 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

>> The static IRQ base is not used on any platforms with this chip
>> (only Ux500). Get rid of it forever, and rely on dynamic IRQ
>> descriptor allocation.
>>
>> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
>> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
(...)
> Does this actually compile? Does this patch have a dependency?

It actually does compile and has no direct dependencies.

> I see TC3589x_INT_GPIO(x) being used still:
>
>   include/linux/mfd/tc3589x.h:
>     #define TC3589x_NR_IRQS                TC3589x_INT_GPIO(TC3589x_NR_GPIOS)

It compiles because TC3589x_NR_IRQS is not uses anywhere,
so this macro is never put to the test.

I'll respin with a much bigger deletion rooting out not only the
static IRQ but also the static GPIO numbering.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html