Re: [PATCH 0/4] pinctrl: sirf: switch to one gpiolib and gpiolib_irqchip helpers

[Javier Martinez Canillas <javier@xxxxxxxxxxxx>]

On Wed, Apr 16, 2014 at 12:05 PM, Barry Song <21cnbao@xxxxxxxxx> wrote:
> 2014-04-16 17:54 GMT+08:00 Javier Martinez Canillas <javier@xxxxxxxxxxxx>:
>> Hello Barry,
>>
>> On Tue, Apr 15, 2014 at 8:43 AM, Barry Song <21cnbao@xxxxxxxxx> wrote:
>>> From: Barry Song <Baohua.Song@xxxxxxx>
>>>
>>> This patchset depends on Linus Walleij's "pinctrl: sirf: rename inlined accessor".
>>> and "pinctrl: sirf: switch driver to use gpiolib irqchip helpers" is rebased
>>> from Linus Walleij's patch too.
>>>
>>> Barry Song (3):
>>>   pinctrl: sirf: wrap all gpio banks into one gpio_chip
>>>   gpio: make handler_data configurable while using gpiolib_irqchip
>>>   pinctrl: sirf: move to use irq_get_handler_data
>>> Linus Walleij (1):
>>>   pinctrl: sirf: switch driver to use gpiolib irqchip helpers
>>>
>>>  drivers/gpio/gpiolib.c              |   10 +-
>>>  drivers/pinctrl/Kconfig             |    1 +
>>>  drivers/pinctrl/sirf/pinctrl-sirf.c |  264 ++++++++++++-----------------------
>>>  include/linux/gpio/driver.h         |    2 +-
>>>  4 files changed, 97 insertions(+), 180 deletions(-)
>>>
>>> --
>>> 1.7.5.4
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>> Maybe you can first do the parameter change to
>> gpiochip_set_chained_irqchip() and then just convert to gpiolib
>> irqchip passing the struct sirfsoc_gpio_bank pointer instead of a
>> struct gpio_chip. I think there is no need to split PATCH 2 and PATCH
>> 4 but it is up to you.
>>
>
> Javier, thanks. the reason for splitting 2 and 4 is that i don't want
> to lose the contribution of Linus for "gpiolib irqchip helpers".
> otherwise, i will be the author of the merged patch.
>

Right, I didn't notice PATCH 2 was from Linus because it didn't have
his Signed-off-by but yours (although now I notice that it was sent
with him as the author).

AFAIK you can still squash both patches and in that case the
convention is to add the original author s-o-b and then explain your
contributions on top. i.e:

From: Linus Walleij <linus.walleij@xxxxxxxxxx>

This switches the SiRF pinctrl driver over to using the gpiolib
irqchip helpers simplifying some of the code.

[Baohua.Song@xxxxxxx: move to use irq_get_handler_data]
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

But it's also OK to have split in two patches, I just asked out of curiosity :-)

Best regards,
Javier

>
>> The series looks good to me:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
>
> -barry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html