Hi, On Thu, Apr 10, 2014 at 07:29:26PM +0200, Linus Walleij wrote: > On Sun, Apr 6, 2014 at 4:58 PM, Javier Martinez Canillas > <javier.martinez@xxxxxxxxxxxxxxx> wrote: > > > Now that you have sent your changes for v3.15 to Torvalds, here are some > > changes for the OMAP GPIO driver targeted to v3.16. Mostly improvements > > so nothing here is -rc material. > > I like this series so I have applied them for v3.16, pending some ACK > from Kevin &| Santosh. I tried these patches on OMAP1 on top of today's Torvalds git (4ba85265790ba3681deeaf73f018c0eb829a7341). On Amstrad E3 I'm getting the following logs: [ 0.156491] omap_gpio omap_gpio.0: Runtime PM disabled, clock forced on. [ 0.164604] genirq: Setting trigger mode 0 for irq 64 failed (gpio_irq_type+0x0/0x1f0) [ 0.165418] genirq: Setting trigger mode 0 for irq 65 failed (gpio_irq_type+0x0/0x1f0) [ 0.166133] genirq: Setting trigger mode 0 for irq 66 failed (gpio_irq_type+0x0/0x1f0) [ 0.166838] genirq: Setting trigger mode 0 for irq 67 failed (gpio_irq_type+0x0/0x1f0) [...] [ 0.182856] genirq: Setting trigger mode 0 for irq 79 failed (gpio_irq_type+0x0/0x1f0) [ 0.186887] omap_gpio omap_gpio.1: Could not get gpio dbck [ 0.189308] genirq: Setting trigger mode 0 for irq 95 failed (gpio_irq_type+0x0/0x1f0) [...] [ 0.203121] genirq: Setting trigger mode 0 for irq 110 failed (gpio_irq_type+0x0/0x1f0) However it still seems to work. The serio is only GPIO IRQ and it triggers when I press the external keyboard. The same happens also on Nokia 770: [ 0.118896] genirq: Setting trigger mode 0 for irq 128 failed (gpio_irq_type+0x0/0x220) [ 0.119201] genirq: Setting trigger mode 0 for irq 129 failed (gpio_irq_type+0x0/0x220) [...] [ 0.124999] genirq: Setting trigger mode 0 for irq 143 failed (gpio_irq_type +0x0/0x220) [ 0.126831] omap_gpio omap_gpio.1: Could not get gpio dbck [ 0.127258] OMAP GPIO hardware version 1.1 [ 0.127624] omap_gpio omap_gpio.2: Could not get gpio dbck [ 0.128204] omap_gpio omap_gpio.3: Could not get gpio dbck [ 0.128753] omap_gpio omap_gpio.4: Could not get gpio dbck Here also GPIO IRQs (touchscreen, Retu) still work. A. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html