Re: [PATCH] gpio: samsung: Add missing "break" statement

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sat, Mar 22, 2014 at 9:35 AM, Alexander Shiyan <shc_work@xxxxxxx> wrote:

> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/gpio/gpio-samsung.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a85e00b..07105ee 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -379,6 +379,7 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
>         case 6:
>                 shift = ((off + 1) & 7) * 4;
>                 reg -= 4;
> +               break;
>         default:
>                 shift = ((off + 1) & 7) * 4;
>                 break;

Obviously no semantic effect so patch applied as it adds code
readability.

But I'm wondering if default should not be doing reg -= 4; as
well?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html