Re: [PATCH v2 1/2] gpio: moxart: Actually set output state in moxart_gpio_direction_output()

[Alexandre Courbot <gnurou@xxxxxxxxx>]

On Tue, Mar 25, 2014 at 11:28 AM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> moxart_gpio_direction_output() ignored the state passed into it. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-moxart.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
> index 2af9900..4bd81f9 100644
> --- a/drivers/gpio/gpio-moxart.c
> +++ b/drivers/gpio/gpio-moxart.c
> @@ -33,6 +33,8 @@ struct moxart_gpio_chip {
>         void __iomem *base;
>  };
>
> +static void moxart_gpio_set(struct gpio_chip *chip, unsigned offset, int value);

Just reverse the order of your patches, and you don't have to make
this declaration at all.

It makes little sense to introduce a forward-declaration in a patch
and remove it in the very next.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html