Re: [PATCH] gpio: samsung: Remove double variable assignment

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sat, Feb 15, 2014 at 2:29 PM, Alexander Shiyan <shc_work@xxxxxxx> wrote:

> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/gpio/gpio-samsung.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a85e00b..929f31e 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -377,7 +377,6 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
>                 reg -= 4;
>                 break;
>         case 6:
> -               shift = ((off + 1) & 7) * 4;
>                 reg -= 4;
>         default:
>                 shift = ((off + 1) & 7) * 4;

This makes perfect sense from a semantic point of view.

But I'm just worried that it may be a syntactic error after all,
such as a break; missing in case 6?

What does Samsung folks say about this?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html