On Mon, Jul 11, 2016 at 09:50:21AM -0700, Linus Torvalds wrote: > On Mon, Jul 11, 2016 at 8:01 AM, Andreas Gruenbacher > <agruenba@xxxxxxxxxx> wrote: > > From: Jeff Layton <jlayton@xxxxxxxxxx> > > > > Currently the two are unioned together, but I don't think that's safe. > > Ack. That does look fishy. Almost anything else can probably be > unioned together with the rcu list, but *not* the refcount that we > might want to look at during the rcu grace period. > > Al, this is your code (from long long ago). Want to take it through > the vfs tree, or should I just apply direectly? I'd like to have your > ack regardless, but the fix looks ObviouslyCorrect(tm) to me. Applied; the mess had been caused by get_cached_acl() switch from ->i_lock to rcu_read_lock. The code is mine, but relevant part is fairly recent. I'll send a pull request tonight, with that thing included. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html