Re: [PATCH] ext4: don't call ext4_should_journal_data() on the journal inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, I've reworded the commit description as follows:

  ext4: don't call ext4_should_journal_data() on the journal inode
  
  If ext4_fill_super() fails early, it's possible for
  ext4_evict_inode() to call ext4_should_journal_data() before
  superblock options and flags are fully set up.  In that case, the
  iput() on the journal inode can end up causing a BUG().
  
  Work around this problem by reordering the tests so we only call
  ext4_should_journal_data() after we know it's not the journal inode.
  
  Fixes: 2d859db3e4 ("ext4: fix data corruption in inodes with journalled data")
  Fixes: 2b405bfa84 ("ext4: fix data=journal fast mount/umount hang")
  Cc: Jan Kara <jack@xxxxxxx>
  Cc: stable@xxxxxxxxxxxxxxx
  Signed-off-by: Vegard Nossum <vegard.nossum@xxxxxxxxxx>
  Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
  Reviewed-by: Jan Kara <jack@xxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux