On Fri, Jul 1, 2016 at 4:54 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > Hi Ming, > > I was reading through the code of loop DIO/AIO > and I was wondering whether lo_req_flush() really > honors REQ_FLUSH by calling vfs_fsync() on a backing file > that is open with O_DIRECT? >From view of device, REQ_FLUSH just flushs the cache inside drive to medium. > > Shouldn't lo_req_flush() actually wait for completion of > all the in-flight loop AIO requests to complete? I think it isn't needed, just like the flush handling in blk-flush.c, and it just works for completed I/O. > Am I missing something? > > Thanks, > Amir. > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html