On Thu, Jun 30, 2016 at 1:09 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 28, 2016 at 10:18:10AM +0200, Miklos Szeredi wrote: >> Hi Al, >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git d_real >> >> This consolidates the d_real/d_select_inode API as well as some documentation >> cleanups. > > Two notes: > > 1) you have 4 places with identical "if DCACHE_OP_REAL is there, > call ->d_real(dentry, ..., ...), otherwise return dentry". And you have > exactly one place where d_real() wrapper is called. Looks like we would > be better off with the calling conventions for wrapper updated as well. > > 2) while we can't turn dentry argument into const struct dentry * (due to > ovl_copy_up()), could we at least do that to the inode one? > > IOW, how about this, on top of that branch? Or fold it into the commit > changing the arguments of ->d_real(), for that matter... Makes sense. Folded, updated doc and force pushed to the same branch. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
