On Sat, Jun 25, 2016 at 3:54 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> BTW, speaking of that area - is there any reason why dentry_cmp()
> isn't simply
> return dentry_string_cmp(lockless_dereference(dentry->d_name.name),
> ct, tcount);
> other than "it predates lockless_dereference()"?
No, the only important thing is that it's a read-once, and has the
smp_read_barrier_depends().
So lockless_derefence() looks like the right thing to do, it is just
that - as you suspected - the code predates that concept.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
