Copying in Al for comment. The patches look good to me though from the
GFS2 perspective. Lets make sure that we do test them very carefully,
since this is a very tricky area to get right,
Steve.
On 20/06/16 16:55, Bob Peterson wrote:
Hi,
This is a set of four patches from Andreas Gruenbacher that fix the
gfs2_lookup_by_inum deadlock problem, plus a few bugs we've uncovered
during testing, and a cleanup or two. I've been working with Andreas
for a while now, and we've both made several attempts to fix this
problem in the past, in regard to the transition of dinodes from the
"unlinked" to the "free" state. This is the latest attempt, and it
seems to be working well.
I sent the first 3 patches on 15 June, and Andreas had posted some of
this as well, but I wanted to add the fourth patch, plus cc linux-fsdevel.
Prior to that, a previous version was posted which included a patch to
VFS, but Al Viro didn't like that. That design was scrapped in favor
of this one, which is simpler and confined to GFS2. Hopefully Al will
like this implementation.
Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Signed-off-by: Bob Peterson <rpeterso@xxxxxxxxxx>
---
Andreas Gruenbacher (4):
gfs2: Fix gfs2_lookup_by_inum lock inversion
gfs2: Get rid of gfs2_ilookup
gfs2: Large-filesystem fix for 32-bit systems
gfs2: Lock holder cleanup
fs/gfs2/dentry.c | 2 +-
fs/gfs2/dir.c | 3 +-
fs/gfs2/export.c | 11 -----
fs/gfs2/file.c | 2 +-
fs/gfs2/glock.c | 11 +----
fs/gfs2/glock.h | 10 ++++
fs/gfs2/inode.c | 128 ++++++++++++++++++++++++++++++++++-----------------
fs/gfs2/inode.h | 4 +-
fs/gfs2/main.c | 2 +-
fs/gfs2/ops_fstype.c | 3 +-
fs/gfs2/quota.c | 2 +-
fs/gfs2/rgrp.c | 4 +-
fs/gfs2/super.c | 24 ++++++----
13 files changed, 123 insertions(+), 83 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
