On Wed 08-06-16 22:04:50, Deepa Dinamani wrote: > CURRENT_TIME is not y2038 safe. > > CURRENT_TIME macro is also not appropriate for filesystems > as it doesn't use the right granularity for filesystem > timestamps. > > Logical Volume Integrity format is described to have the > same timestamp format for "Recording Date and time" as > the other [a,c,m]timestamps. > Hence using current_fs_time() instead here promises to > maintain the same granularity as other timestamps. > > This is also in preparation for the patch that transitions > vfs timestamps to use 64 bit time and hence make them > y2038 safe. As part of the effort current_fs_time() will be > extended to do range checks. Just one nit below. > @@ -2030,7 +2030,7 @@ static void udf_close_lvid(struct super_block *sb) > mutex_lock(&sbi->s_alloc_mutex); > lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX; > lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX; > - udf_time_to_disk_stamp(&lvid->recordingDateAndTime, CURRENT_TIME); > + udf_time_to_disk_stamp(&lvid->recordingDateAndTime, current_fs_time(sb)); > if (UDF_MAX_WRITE_VERSION > le16_to_cpu(lvidiu->maxUDFWriteRev)) > lvidiu->maxUDFWriteRev = cpu_to_le16(UDF_MAX_WRITE_VERSION); > if (sbi->s_udfrev > le16_to_cpu(lvidiu->minUDFReadRev)) Please wrap this line properly so that it does not exceed 80 characters. Other than that feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
