On Thu, 2016-06-02 at 01:32 -0700, Christoph Hellwig wrote:
> > -static inline u_long
> > -dir_pages(struct inode *inode)
> > -{
> > - return (inode->i_size + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
> > -}
>
> This is still against a different tree than my branch, right?
yes, it is.
>
> Othwrwise the readdir changes look fine minus a few very minor
> codingstyle issues that I'll happily fix up
many thanks :)
>
> > @@ -212,17 +190,17 @@ vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags)
> > {
> > struct inode *ip = NULL;
> > ino_t ino;
> > -
> > +
> > if (dp->d_name.len > VXFS_NAMELEN)
> > return ERR_PTR(-ENAMETOOLONG);
> > -
> > +
> > ino = vxfs_inode_by_name(dip, dp);
> > if (ino) {
> > ip = vxfs_iget(dip->i_sb, ino);
> > if (IS_ERR(ip))
> > return ERR_CAST(ip);
> > + d_add(dp, ip);
> > }
> > - d_add(dp, ip);
> > return NULL;
>
> This change is unrelated to the readdir changes, and it looks incorrect
> to me. If we don't find an inode for a lookup we still want to call
> d_add with a NULL inode - this creates a so called negative dentry,
> which tells the VFS to not bother looking up this file name next time.
I see. Thank you for explanation of d_add() semantics, so you are right,
it was wrong change.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Krzysztof Blaszkowski
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
