On Wed, Jun 01, 2016 at 11:23:32AM +0200, Krzysztof B??aszkowski wrote: > I think that there are no "kfree(pfp); kfree(sfp); return 0;" in > vxfs_read_fshead() still. Are pfp and sfp needed anywhere ? I am sure > they are not so there is a memory leak without these kfrees every mount. > > I am not sure absolutely of that read_fshead() is missing these kfrees > because I have seen just these diffs, anyway I did not notice "+kfree". The frees are still missing. Do you want to send me a patch for those? > needles to say that I prefer to have limited scope of visibility of > inode_cachep to the inode.c only. In my tree the visibility is in vxfs_super.c only. Given that the alloc/destroy methods are super operations that seems to fit better as they can have local scope, too. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
