On Sat, May 28, 2016 at 08:56:39PM -0400, Zygo Blaxell wrote: > On Sun, May 29, 2016 at 02:21:03AM +0200, Adam Borowski wrote: > > In any case, this patch doesn't introduce any cases not already triggerable > > by root. > > It allows non-root to trigger cases that previously could only be > triggered by root. Only the proposed "ro is enough" variant does. The patch, as written, requires write permission on the inode, thus alleviating your concerns: * mangling the contents of dstfile: the user has rw access so he can do that already * triggering a bug: the user could have opened dstfile rw (like duperemove currently does) Meow! -- An imaginary friend squared is a real enemy. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html