Seth Forshee <seth.forshee@xxxxxxxxxxxxx> writes: > On Wed, May 18, 2016 at 10:45:31AM -0500, Eric W. Biederman wrote: >> > But if we do that it violates some of the assumptions of the patch to >> > rework MNT_NODEV on your testing branch (and also those behind patch 2 >> > in this series). Something will need to be changed there to prevent a >> > regression in mount behavior when a user ns tries to mount without >> > MNT_NODEV when the mount inherited from its parent has it set. >> >> Thank you for pointing that out. I will look into that. >> >> I believe I know exactly what you are talking about. Of the choices I >> think it is better to a minor localized change in the fs_fully_visible >> logic than it is to cause problems elsewhere. > > Agreed. > >> >> Apologies for not catching this earlier. >> > >> > Actually this is a more recent patch, so you possibly hadn't seen it >> > before. >> > >> >> I am looking at folding all of this into the patch that introduces >> >> sget_userns so that even bisects won't have regresssions. >> > >> > That's fine with me. >> >> And thank you for keeping everything as separate patches. That is at >> least helping me catch up. Even if I don't agree that these things >> should be separate come merge time. > > Honestly I probably would have squashed some of them into that first > patch myself if you hadn't already applied it to your testing branch, so > that's all just luck. > > Keep in mind that I also have that patch for mqueue that isn't in this > series, and I haven't yet checked to see if the 4.7 merges introduce > anything which is going to require updating these patches. I was > planning to wait and send out updates after -rc1, but if you want that > stuff sooner just let me know. As unfortunately I don't have anything going into -rc1 I am working on this right now. Let me finish sorting out the sget_userns and mnt nodev mess and I will push something out and then we can compare notes. I think I have mqueue covered by other changes. As it is in the set of filesystems that should just use sget_userns. I am sorting through the nodev corner of this now. It should just be a day or two. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
