On Tue, May 17, 2016 at 2:10 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > Having said that, what happens when ovl_workdir_create() fails and we > mount overlayfs read only. In that case I think we will conclude that > underlying fs does not support d_type and mounting will fail. Good point, I missed that. > Any thoughts, on how to handle this failure path better? Just skip the d_type test. We won't create whiteouts that way (and whiteouts would only have been created with a previous kernel that didn't have this test, which I don't think is a very interesting case). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html