On Mon, May 09, 2016 at 07:47:04AM +1000, NeilBrown wrote: > On Fri, Mar 04 2016, Christoph Hellwig wrote: > > > This adds a flag that tells the file system that this is a high priority > > request for which it's worth to poll the hardware. The flag is purely > > advisory and can be ignored if not supported. > > Here you say the flag is "advice". > > > > > +/* flags for preadv2/pwritev2: */ > > +#define RWF_HIPRI 0x00000001 /* high priority request, poll if possible */ > > This text makes it sound like a firm "request" ("if possible"). "request" here is in the sense of an I/O request. Better wording highly welcome. > > > provides lower latency, but may use additional ressources > > Is this a "latency vs throughput" trade-off, or something more subtle? > It would be nice to make the decision process as obvious as possible for > the developer considering the use of this flag. If you poll you can't do anything else, so you end up using CPU cycles to wait which otherwise could do something productive. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html