On Thu, 2016-05-05 at 07:21 -0700, Christoph Hellwig wrote:
> >
> > if (mp->m_flags & XFS_MOUNT_DAX) {
> > + struct blk_dax_ctl dax = {
> > + .sector = 0,
> > + .size = PAGE_SIZE,
> > + };
>
> I'm pretty sure I already complained last week, but this boiler plate
> code has no business in every file systems. Also it seems to me like
> this struct blk_dax_ctl calling convention is stupid to start with,
> why not pass the arguments directly and avoid the boilerplate code
> everywhere?
Sorry, I was wondering about if we should also consolidate error messages.
Per the thread below, I am going to add a helper function to do it.
https://lkml.org/lkml/2016/5/4/887
Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
