On Mon, Apr 25, 2016 at 05:15:36PM -0700, Jaegeuk Kim wrote: > This patch removes the most parts of internal crypto codes. > And then, it modifies and adds some ext4-specific crypt codes to use the generic > facility. > > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> So I just tried this patch, and one big problem with it is that it breaks backwards compatibility with existing userspace code, which assumes that the name of the keys are prefixed with "ext4:". I see that in fs/crypto.h you've changed it to be "fscrypto:". Which is more general, perhaps, but the problem is that it's not what the existing shipping code (for example, in the Android N preview release) and what e2fsprogs's e4crypto is using. If we want to use fscrypto: as a more general prefix, I could see doing that, but we need to provide for backwards compatibility --- which means that at least for ext4, we will need to look for keys using both the new and old prefix, and we would also want change e4crypto to set keys with both the "ext4" and the more general "fscrypto" prefix. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
