Re: [PATCH 3/5] kernfs: Switch to generic xattr handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 30, 2016 at 10:02:31AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Apr 29, 2016 at 04:18:35PM +0200, Andreas Gruenbacher wrote:
> > Unlike with most other filesystems, xattrs in kernfs are attached to the
> > dentries (dentry->d_fsdata).  Once security modules start calling get
> > xattr handlers with a NULL dentry (because of an unknown dentry), we'll
> > have to start check for that in kernfs_xattr_get.
> > 
> > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> Note, I'm not the only maintainer of kernfs...
> 
> Anyway:
> 	Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Guys, kernfs uses ->d_fsdata to get to them, but note
static void kernfs_init_inode(struct kernfs_node *kn, struct inode *inode)
{
        kernfs_get(kn);
        inode->i_private = kn;
IOW, inode->i_private would work just as well - it points to the same thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux