Re: [PATCH 1/3] writeback: propagate the various reasons for writeback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 12-04-16 12:43:51, Jens Axboe wrote:
> Avoid losing context by propagating the various reason why we
> initiate writeback. If we are doing more important reclaim or
> synchronous writeback, the lower levels should know about it.
> 
> No intended functional changes in this patch.

So far 'reason' is only used for tracing and I'd strongly prefer to keep it
as such - otherwise the mix of flags like for_sync, for_backround, ...  and
'reason' gets really messy. If you need more information propagated via
wb_start_writeback() just add more flag arguments (currently there is only
range_cyclic flag). Since there would be already three flag arguments,
maybe it would warrant using a 'flags' argument which would be a standard
bitmask of desired flags...

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux