Re: [PATCH v2] vfs: constify arguments to utime family of system calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 31, 2016 at 08:51:12PM -0500, Eric Biggers wrote:
> The system calls to set file times: utime(), utimes(), futimesat(), and
> utimensat(), all take in pointers to a filename and time information,
> neither of which is modified.  Mark the pointed-to data as 'const' to
> better reflect the semantics.

I'm not sure if there's any point, to be honest.  Anything doing direct
dereferencing of those pointers is completely broken and reads are no
better than writes in that respect.  OTOH... put_user() and friends will
produce an error when you give them const void __user * on most of the
architectures, so it's not entirely useles...

What's the situation with other syscalls?  It doesn't make much sense
to do it piece-by-piece...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux