On 03/15/2016 04:45 PM, Seth Forshee wrote:
On Tue, Mar 15, 2016 at 03:09:00PM +0300, Pavel Tikhomirov wrote:
If in_userns returns false mnt_may_suid also returns false, and we
will reach second(removed) if-check only in case it does not trigger,
so remove it.
We had a somewhat lengthy discussion previously where one of the
conclusions was that we'd have that check in both places even though
it's redundant. Iirc the reason was that though they're doing the same
test they're doing so to answer different questions, so we should have
the test in both places (or something along those lines).
Ok, that is reasonable. But from my POV the edge between the meaning of
those checks is quiet blurred.
Thanks!
Thanks,
Seth
--
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
