On Wed, Mar 02, 2016 at 01:01:57PM -0600, Frank Sorenson wrote: > There is currently no visibility into when or how > a filesystem became frozen, and no record of freeze/ > thaw activity. Add tracepoints for these events. NAK. > + TP_fast_assign( > + memcpy(__entry->comm, current->comm, TASK_COMM_LEN); > + memcpy(__entry->super_id, sb->s_id, SUPER_ID_MAX_LEN); > + memcpy(__entry->fstype, sb->s_type->name, FSTYPE_MAX_LEN); > + __entry->dev = sb->s_dev; > + __entry->frozen = sb->s_writers.frozen; This turns the value of ->s_writers.frozen into a fucking userland ABI. Committing us to maintain it forever. No, thanks. BTW, how is your "record the pid" supposed to interact with containers and pidns? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
