Re: [PATCH] remove warn when bdi is unregisterd in __mark_inode_dirty().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 29, 2016 at 03:03:54PM +0800, zhangaihua1@xxxxxxxxxx wrote:
> From: zhangaihua <zhangaihua1@xxxxxxxxxx>
> 
> When a disk is ejected, we try to do the operation 'ls', it will fails
> because device is gone.
> 
> Currently we do a WARN() which does not seem to be the right thing.
> Convert it to a ratelimited kernel warning.

I don't think this is a good idea - the stack trace is required to
determine what code has failed to detect that the device has gone
and is trying to continue onwards without handling errors correctly.

IMO, iterate_dir() should be fixed to do the right thing when
errors have occurred....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux