On Wed, 24 Feb 2016, Al Viro wrote: > Since "HPFS: Introduce a global mutex and lock it on every callback > from VFS" we had a deadlock in the "can't delete directory entry due to > lack of space, try to truncate the sucker first" path - hpfs_lock() held > through the area that contains notify_change() and hpfs_setattr() grabs > it again. BKL != mutex... > > We could try to deal with that, but really, why not simply fail with > -ENOSPC there? It still can happen, even after truncate, so it's not as if > the userland didn't have to cope with it. And doing that would eliminate > the last user of dentry_unhash(), allowing to kill that crap as well... Yes, I think it's better to just fail instead of truncating the file. Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
