On Tue, Feb 16 2016, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Feb 16, 2016 at 11:49:24PM +0100, Rasmus Villemoes wrote: >> I noticed that offsetof(struct filename, iname) is actually 28 on 64 >> bit platforms, so we always pass an unaligned pointer to >> strncpy_from_user. This is mostly a problem for those 64 bit platforms >> without HAVE_EFFICIENT_UNALIGNED_ACCESS, but even on x86_64, unaligned >> accesses carry a penalty, especially when done in a loop. >> >> Let's try to ensure we always pass an aligned destination pointer to >> strncpy_from_user. I considered making refcnt a long instead of doing >> the union thing, and mostly ended up tossing a coin. > > Why not swap it with the previous field, then? Sure, that would work as well. I don't really care how ->iname is pushed out to offset 32, but I'd like to know if it's worth it. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
