On Sat 30-01-16 00:28:33, Matthew Wilcox wrote: > On Fri, Jan 29, 2016 at 11:28:15AM -0700, Ross Zwisler wrote: > > I guess I need to go off and understand if we can have DAX mappings on such a > > device. If we can, we may have a problem - we can get the block_device from > > get_block() in I/O path and the various fault paths, but we don't have access > > to get_block() when flushing via dax_writeback_mapping_range(). We avoid > > needing it the normal case by storing the sector results from get_block() in > > the radix tree. > > I think we're doing it wrong by storing the sector in the radix tree; we'd > really need to store both the sector and the bdev which is too much data. > > If we store the PFN of the underlying page instead, we don't have this > problem. Instead, we have a different problem; of the device going > away under us. I'm trying to find the code which tears down PTEs when > the device goes away, and I'm not seeing it. What do we do about user > mappings of the device? So I don't have a strong opinion whether storing PFN or sector is better. Maybe PFN is somewhat more generic but OTOH turning DAX off for special cases like inodes on XFS RT devices would be IMHO fine. I'm somewhat concerned that there are several things in flight (page fault rework, invalidation on device removal, issues with DAX access to block devices Ross found) and this is IMHO the smallest trouble we have and changing this seems relatively invasive. So could we settle the fault code and similar stuff first and look into this somewhat later? Because frankly I have some trouble following how all the pieces are going to fit together and I'm afraid we'll introduce some non-trivial bugs when several fundamental things are in flux in parallel. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
